Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Twenty & WP 5.3 Compatibility #277

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Twenty Twenty & WP 5.3 Compatibility #277

merged 2 commits into from
Nov 11, 2019

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented Nov 8, 2019

We're mostly all OK for compatibility with WordPress 5.3, the only exceptions are some display issues with Twenty Twenty. The content area is more narrow, and the markup is slightly different. This updates the schedule display to use alignwide styles if there are more than two tracks (otherwise it breaks out of the space), and now looks for and uses the theme's template for the Day of Event page. The offline page still looks wonky, but we can address that with #205.

Other core changes to note:

The media improvements seem to be mostly around resizing images or hooking into the upload process, so our uploads are good (we use the media library directly). There’s no change to wp_unique_filename, so obscuring the filenames should continue to work.

Things we should watch for:

An enhancement we could make: any meta fields exposed by the API can now define a schema in the register_post_meta call. We don't seem to need this anywhere ATM, but useful to know about. WP 5.3 Supports Object and Array Meta Types in the REST API

To test

To test these changes specifically:

  • Make sure a page with a schedule still looks OK
  • Check that the Day of Event template works

Otherwise, checking out the 5.3 branch in mu/ while you're working from now on would be a good way to test 👍

Twenty Twenty has a very narrow content width, schedules with more than 2 tracks will look cramped & hard to read, or be cut off the page. By using `alignwide` we get a little more space. Camps with 4+ tracks will likely need custom styles, if it becomes a common problem we can handle it then.
@ryelle ryelle added [Status] Needs Review [Component] Themes & Customization Custom WC Themes, compatibility with core themes, and theme-adjacent customizations to sites labels Nov 8, 2019
@ryelle ryelle self-assigned this Nov 8, 2019
Copy link
Member

@iandunn iandunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@iandunn
Copy link
Member

iandunn commented Nov 11, 2019

Otherwise, checking out the 5.3 branch in mu/ while you're working from now on would be a good way to test 👍

That's a great reminder, I'd forgotten to do that for this release. I wonder if there's a way that we can automatically remind ourselves to do that when each time a beta1 is released? Nothing easy is coming to mind, but figured I'd throw it out there in case anyone else has an idea.

@ryelle ryelle merged commit f9b75ce into production Nov 11, 2019
@ryelle ryelle deleted the update/5.3-compat branch November 11, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Themes & Customization Custom WC Themes, compatibility with core themes, and theme-adjacent customizations to sites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants