Twenty Twenty & WP 5.3 Compatibility #277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're mostly all OK for compatibility with WordPress 5.3, the only exceptions are some display issues with Twenty Twenty. The content area is more narrow, and the markup is slightly different. This updates the schedule display to use
alignwide
styles if there are more than two tracks (otherwise it breaks out of the space), and now looks for and uses the theme's template for the Day of Event page. The offline page still looks wonky, but we can address that with #205.Other core changes to note:
The media improvements seem to be mostly around resizing images or hooking into the upload process, so our uploads are good (we use the media library directly). There’s no change to
wp_unique_filename
, so obscuring the filenames should continue to work.Things we should watch for:
TypeError
JS errors – WordPress 5.3: Backbone Upgrade Guidetime()
instead ofcurrent_time( ‘timestamp’ )
, but the latter should continue to work – Date/Time component improvements in WordPress 5.3An enhancement we could make: any meta fields exposed by the API can now define a schema in the
register_post_meta
call. We don't seem to need this anywhere ATM, but useful to know about. WP 5.3 Supports Object and Array Meta Types in the REST APITo test
To test these changes specifically:
Otherwise, checking out the
5.3
branch inmu/
while you're working from now on would be a good way to test 👍